Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(datastore): support updating table with schema embedded records #3064

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Dec 6, 2023

Description

Added a new API: /datastore/updateTable/embedded to support update requests for embedded types in each cell.

The following issues were resolved:

  1. Scanned data could not be used directly for update.
  2. Clients previously had to build a batch based on the schema, but with the new API, they only need to concern themselves with the batch size.
  3. The datastore migration doesn't need to be built-in to the datastore, any external business logic can manage it.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui changed the title New ds api enhance(datastore): support updating table with schema embedded records Dec 6, 2023
@jialeicui jialeicui marked this pull request as draft December 6, 2023 07:32
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (807d59f) 82.60% compared to head (7490be0) 82.71%.

Files Patch % Lines
...a/ai/starwhale/mlops/datastore/type/ListValue.java 88.57% 2 Missing and 2 partials ⚠️
.../starwhale/mlops/datastore/impl/RecordDecoder.java 90.90% 1 Missing and 2 partials ⚠️
...va/ai/starwhale/mlops/datastore/type/MapValue.java 92.10% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3064      +/-   ##
============================================
+ Coverage     82.60%   82.71%   +0.10%     
- Complexity     3182     3230      +48     
============================================
  Files           571      571              
  Lines         31838    32019     +181     
  Branches       1865     1885      +20     
============================================
+ Hits          26301    26483     +182     
+ Misses         4711     4705       -6     
- Partials        826      831       +5     
Flag Coverage Δ
console 72.09% <ø> (ø)
controller 73.53% <93.33%> (+0.19%) ⬆️
standalone 91.87% <100.00%> (+0.07%) ⬆️
unittests 91.61% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianweidut tianweidut merged commit 411c05d into star-whale:main Jan 22, 2024
43 checks passed
@jialeicui jialeicui deleted the new-ds-api branch January 22, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants