Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): storage file service support put method #3036

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Nov 27, 2023

Description

  1. make file type object store support file type
  2. server signed url are sourced from request server name
    cc @tianweidut

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (39bc0bc) 82.74% compared to head (1ea6e5a) 73.92%.
Report is 12 commits behind head on main.

Files Patch % Lines
...starwhale/mlops/storage/fs/FsStorageSignature.java 76.19% 5 Missing ⚠️
.../ai/starwhale/mlops/api/ObjectStoreController.java 69.23% 2 Missing and 2 partials ⚠️
...ale/mlops/storage/fs/StorageAccessServiceFile.java 83.33% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3036      +/-   ##
============================================
- Coverage     82.74%   73.92%   -8.83%     
- Complexity     3157     3167      +10     
============================================
  Files           558      431     -127     
  Lines         30635    15433   -15202     
  Branches       1838     1786      -52     
============================================
- Hits          25350    11409   -13941     
+ Misses         4473     3209    -1264     
- Partials        812      815       +3     
Flag Coverage Δ
console ?
controller 73.92% <78.18%> (+<0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anda-ren anda-ren marked this pull request as ready for review November 28, 2023 02:27
@anda-ren anda-ren requested a review from jialeicui November 29, 2023 03:42
@anda-ren anda-ren requested a review from jialeicui November 29, 2023 07:21
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 73d35ef into star-whale:main Nov 29, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants