Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): support ksyun #2986

Merged
merged 1 commit into from
Nov 16, 2023
Merged

feat(storage): support ksyun #2986

merged 1 commit into from
Nov 16, 2023

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Nov 16, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 87 lines in your changes are missing coverage. Please review.

Comparison is base (147ff2e) 82.97% compared to head (c77ae3f) 73.31%.
Report is 1 commits behind head on main.

Files Patch % Lines
...mlops/storage/ksyun/StorageAccessServiceKsyun.java 0.00% 82 Missing ⚠️
...un/CompatibleStorageAccessServiceBuilderKsyun.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2986      +/-   ##
============================================
- Coverage     82.97%   73.31%   -9.66%     
+ Complexity     3114     3109       -5     
============================================
  Files           557      436     -121     
  Lines         30360    15160   -15200     
  Branches       1829     1760      -69     
============================================
- Hits          25190    11114   -14076     
+ Misses         4364     3246    -1118     
+ Partials        806      800       -6     
Flag Coverage Δ
console ?
controller 73.31% <0.00%> (-0.74%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuchuan xuchuan merged commit 855b540 into star-whale:main Nov 16, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants