Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): fill SFT list fields #2980

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

anda-ren
Copy link
Member

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4a93aca) 82.98% compared to head (2277bef) 74.05%.

Files Patch % Lines
.../starwhale/mlops/domain/ft/FineTuneAppService.java 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2980      +/-   ##
============================================
- Coverage     82.98%   74.05%   -8.94%     
  Complexity     3113     3113              
============================================
  Files           558      431     -127     
  Lines         30352    15121   -15231     
  Branches       1826     1766      -60     
============================================
- Hits          25188    11198   -13990     
+ Misses         4359     3121    -1238     
+ Partials        805      802       -3     
Flag Coverage Δ
console ?
controller 74.05% <71.42%> (-0.03%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anda-ren anda-ren marked this pull request as ready for review November 15, 2023 07:51
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren changed the title feat(controller): fill rt list fields feat(controller): fill SFT list fields Nov 15, 2023
@anda-ren anda-ren merged commit ee53554 into star-whale:main Nov 15, 2023
17 checks passed
@anda-ren anda-ren deleted the sft/info branch November 15, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants