Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): add dataset info for step spec #2972

Conversation

goldenxinxing
Copy link
Contributor

Description

releated #2962 cc @waynelwz

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2972 (7026dc3) into main (dcc5c61) will decrease coverage by 8.98%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2972      +/-   ##
============================================
- Coverage     83.04%   74.07%   -8.98%     
+ Complexity     3107     3105       -2     
============================================
  Files           558      432     -126     
  Lines         30395    15121   -15274     
  Branches       1818     1757      -61     
============================================
- Hits          25242    11201   -14041     
+ Misses         4347     3116    -1231     
+ Partials        806      804       -2     
Flag Coverage Δ
console ?
controller 74.07% <ø> (-0.05%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/ai/starwhale/mlops/domain/job/spec/StepSpec.java 100.00% <ø> (ø)

... and 130 files with indirect coverage changes

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit e942bd1 into star-whale:main Nov 13, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants