Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(console): use swagger template api and schema as default api #2955

Merged
merged 3 commits into from
Nov 9, 2023
Merged

update(console): use swagger template api and schema as default api #2955

merged 3 commits into from
Nov 9, 2023

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Nov 9, 2023 •
edited
Loading

Description

image

Y5aJM2iwM5

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

Merging #2955 (231ae23) into main (ce17e0e) will decrease coverage by 10.81%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #2955       +/-   ##
=============================================
- Coverage     82.89%   72.09%   -10.81%     
=============================================
  Files           548        3      -545     
  Lines         29793      215    -29578     
  Branches       1801       61     -1740     
=============================================
- Hits          24697      155    -24542     
+ Misses         4302       58     -4244     
+ Partials        794        2      -792
Flag Coverage Δ
console 72.09% <ø> (ø)
controller ?
standalone ?
unittests 72.09% <ø> (-19.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 545 files with indirect coverage changes

@waynelwz waynelwz changed the title update(console): use swagger template api and schema as default api wip update(console): use swagger template api and schema as default api Nov 9, 2023
@waynelwz waynelwz changed the title wip update(console): use swagger template api and schema as default api update(console): use swagger template api and schema as default api Nov 9, 2023
@jialeicui jialeicui added the console 🎨 console label Nov 9, 2023
jialeicui
jialeicui approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 84d577a into star-whale:main Nov 9, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jialeicui jialeicui jialeicui approved these changes

Assignees
No one assigned
Labels
console 🎨 console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waynelwz @jialeicui