Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): project update to private when pass null by api #2943

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Nov 7, 2023

Description

Modules

  • UI
  • Controller
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2943 (a85a954) into main (b6f5301) will decrease coverage by 17.68%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #2943       +/-   ##
=============================================
- Coverage     91.81%   74.14%   -17.68%     
- Complexity        0     3071     +3071     
=============================================
  Files           126      421      +295     
  Lines         15118    14803      -315     
  Branches         61     1734     +1673     
=============================================
- Hits          13881    10976     -2905     
- Misses         1235     3035     +1800     
- Partials          2      792      +790     
Flag Coverage Δ
console ?
controller 74.14% <100.00%> (?)
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...starwhale/mlops/domain/project/ProjectService.java 73.80% <100.00%> (ø)

... and 546 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 270da64 into star-whale:main Nov 7, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants