Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): support job event with filter/download/fullscreen etc #2935

Merged
merged 8 commits into from
Nov 2, 2023

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Nov 2, 2023

Description

job-event-list.webm

dEqxsEJRpF

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz added feature ✨ new feature console 🎨 console labels Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2935 (c61e5c9) into main (86cbb23) will decrease coverage by 10.96%.
Report is 6 commits behind head on main.
The diff coverage is 40.00%.

@@              Coverage Diff              @@
##               main    #2935       +/-   ##
=============================================
- Coverage     83.04%   72.09%   -10.96%     
=============================================
  Files           546        3      -543     
  Lines         29759      215    -29544     
  Branches       1772       61     -1711     
=============================================
- Hits          24713      155    -24558     
+ Misses         4259       58     -4201     
+ Partials        787        2      -785     
Flag Coverage Δ
console 72.09% <40.00%> (-0.77%) ⬇️
controller ?
standalone ?
unittests 72.09% <40.00%> (-19.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...packages/starwhale-core/src/datastore/constants.ts 100.00% <100.00%> (ø)
...ale-core/src/datastore/schemas/TableQueryFilter.ts 53.76% <0.00%> (-1.80%) ⬇️

... and 543 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 41d9e15 into star-whale:main Nov 2, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console 🎨 console feature ✨ new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants