Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(console): support embedded online eval page #2928

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Oct 31, 2023

Description

online demo: http://jialei.pre.intra.starwhale.ai/projects/1/jobs/26/servings

(It does not need the gradio~=3.15.0, any version is ok)

Note that the broken example preview is a bug of gradio, it does not allow the file access with any part starting with dot.
https://github.com/gradio-app/gradio/blob/ba4c6d9e65138c97062d1757d2a588c4fc449daa/gradio/routes.py#L361-L365
The main branch has removed the logic.

cc @tianweidut @lijing-susan @weijie00123

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #2928 (330fad1) into main (e7a1780) will decrease coverage by 18.90%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2928       +/-   ##
===========================================
- Coverage   91.74%   72.85%   -18.90%     
===========================================
  Files         126        3      -123     
  Lines       15099      210    -14889     
  Branches       59       59               
===========================================
- Hits        13853      153    -13700     
+ Misses       1244       55     -1189     
  Partials        2        2               
Flag Coverage Δ
console 72.85% <ø> (ø)
standalone ?
unittests 72.85% <ø> (-18.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 123 files with indirect coverage changes

@jialeicui jialeicui added enhancement ❤️ New feature or request console 🎨 console labels Oct 31, 2023
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynelwz waynelwz merged commit ede0847 into star-whale:main Nov 1, 2023
17 checks passed
@jialeicui jialeicui deleted the iframe-serving branch November 1, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console 🎨 console enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants