Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): make online eval runable #2914

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Oct 27, 2023

Description

+ compatibility_check
+ '[' -z '' ']'
+ echo '-->[Error] The following variables are missing: SW_PROJECT_URI or SW_MODEL_URI or SW_RUNTIME_URI, possible reason: your server version is lower, please upgrade the server to at least 0.6.0, now will exit.'
+ exit 1
-->[Error] The following variables are missing: SW_PROJECT_URI or SW_MODEL_URI or SW_RUNTIME_URI, possible reason: your server version is lower, please upgrade the server to at least 0.6.0, now will exit.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added bug 🐛 Something isn't working controller 🏘️ labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2914 (23d788d) into main (6114b4e) will decrease coverage by 9.07%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2914      +/-   ##
============================================
- Coverage     83.17%   74.10%   -9.07%     
  Complexity     3017     3017              
============================================
  Files           544      419     -125     
  Lines         29505    14518   -14987     
  Branches       1744     1683      -61     
============================================
- Hits          24540    10759   -13781     
+ Misses         4184     2980    -1204     
+ Partials        781      779       -2     
Flag Coverage Δ
console ?
controller 74.10% <100.00%> (+0.06%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...r/impl/OnlineEvaluationContainerSpecification.java 89.79% <100.00%> (+3.68%) ⬆️
.../impl/SwCliModelHandlerContainerSpecification.java 88.37% <ø> (ø)

... and 128 files with indirect coverage changes

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 5a4073b into star-whale:main Oct 27, 2023
17 checks passed
@jialeicui jialeicui deleted the online-eval-fix branch October 27, 2023 07:29
@jialeicui
Copy link
Contributor Author

cc @tianweidut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working controller 🏘️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants