Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): prefer using builtin list when building dataset #2913

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2913 (2e60c3d) into main (6114b4e) will increase coverage by 9.12%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2913      +/-   ##
============================================
+ Coverage     83.17%   92.29%   +9.12%     
============================================
  Files           544      122     -422     
  Lines         29505    14786   -14719     
  Branches       1744        0    -1744     
============================================
- Hits          24540    13647   -10893     
+ Misses         4184     1139    -3045     
+ Partials        781        0     -781     
Flag Coverage Δ
console ?
controller ?
standalone 92.29% <100.00%> (+0.02%) ⬆️
unittests 92.29% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/starwhale/api/_impl/data_store.py 93.36% <100.00%> (+0.33%) ⬆️
client/starwhale/core/dataset/tabular.py 97.46% <100.00%> (-0.66%) ⬇️

... and 422 files with indirect coverage changes

@tianweidut tianweidut merged commit 872e4b1 into star-whale:main Oct 27, 2023
42 checks passed
@jialeicui jialeicui deleted the prefer-using-builtin-list branch October 27, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants