Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): ignore k8s job fail reason and refine task finish time #2912

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Oct 27, 2023

Description

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2912 (b2eb679) into main (6114b4e) will decrease coverage by 9.10%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2912      +/-   ##
============================================
- Coverage     83.17%   74.07%   -9.10%     
+ Complexity     3017     3016       -1     
============================================
  Files           544      419     -125     
  Lines         29505    14505   -15000     
  Branches       1744     1683      -61     
============================================
- Hits          24540    10745   -13795     
+ Misses         4184     2981    -1203     
+ Partials        781      779       -2     
Flag Coverage Δ
console ?
controller 74.07% <100.00%> (+0.03%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/schedule/impl/k8s/reporting/JobEventHandler.java 71.11% <100.00%> (-1.53%) ⬇️
...ting/listener/impl/RunUpdateListenerForStatus.java 78.94% <100.00%> (+5.73%) ⬆️

... and 127 files with indirect coverage changes

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 97e0343 into star-whale:main Oct 27, 2023
17 checks passed
@jialeicui jialeicui deleted the task-finish-tm branch October 27, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants