chore(controller): datastore use read-write lock #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldenxinxing
force-pushed
the
chore/use_read_write_lock_in_datastore
branch
from
578422f
to
a131990
Compare
goldenxinxing
force-pushed
the
chore/use_read_write_lock_in_datastore
branch
from
a131990
to
d0baf45
Compare
Codecov Report
@@ Coverage Diff @@
## main #2895 +/- ##
============================================
- Coverage 83.52% 74.31% -9.22%
- Complexity 3015 3018 +3
============================================
Files 542 417 -125
Lines 29765 14404 -15361
Branches 1724 1665 -59
============================================
- Hits 24861 10704 -14157
+ Misses 4137 2934 -1203
+ Partials 767 766 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jialeicui
reviewed
Oct 23, 2023
server/controller/src/main/java/ai/starwhale/mlops/datastore/DataStore.java
Show resolved
Hide resolved
server/controller/src/main/java/ai/starwhale/mlops/datastore/DataStore.java
Show resolved
Hide resolved
server/controller/src/main/java/ai/starwhale/mlops/datastore/impl/MemoryTableImpl.java
Show resolved
Hide resolved
server/controller/src/main/java/ai/starwhale/mlops/datastore/impl/MemoryTableImpl.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test case(use 200 thread to scan the same table which has 20w data)
Speed up the scan processing on multi scan request case.
Modules
Checklist