Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(client): enqueue None to the abs queue after artifact close operation #2894

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added bug 🐛 Something isn't working client 🌈 labels Oct 23, 2023
@tianweidut tianweidut self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2894 (2845f8e) into main (1a716ae) will increase coverage by 8.94%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2894      +/-   ##
============================================
+ Coverage     83.52%   92.46%   +8.94%     
============================================
  Files           542      122     -420     
  Lines         29765    15158   -14607     
  Branches       1724        0    -1724     
============================================
- Hits          24861    14016   -10845     
+ Misses         4137     1142    -2995     
+ Partials        767        0     -767     
Flag Coverage Δ
console ?
controller ?
standalone 92.46% <100.00%> (+<0.01%) ⬆️
unittests 92.46% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/starwhale/base/artifact/base.py 98.90% <100.00%> (+0.01%) ⬆️

... and 420 files with indirect coverage changes

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 2e35264 into star-whale:main Oct 23, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working client 🌈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants