Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(console): eval bar support datepicker with range/time/calender selector #2885

Merged
merged 8 commits into from
Oct 19, 2023

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Oct 19, 2023

Description

60c38ef7-cd44-441b-818d-789df39c2702

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2885 (99f3b08) into main (149c8aa) will decrease coverage by 19.51%.
The diff coverage is 27.77%.

@@             Coverage Diff             @@
##             main    #2885       +/-   ##
===========================================
- Coverage   92.35%   72.85%   -19.51%     
===========================================
  Files         125        3      -122     
  Lines       15351      210    -15141     
  Branches       44       59       +15     
===========================================
- Hits        14178      153    -14025     
+ Misses       1173       55     -1118     
- Partials        0        2        +2     
Flag Coverage Δ
console 72.85% <27.77%> (-9.73%) ⬇️
standalone ?
unittests 72.85% <27.77%> (-19.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...packages/starwhale-core/src/datastore/constants.ts 100.00% <100.00%> (ø)
...ale-core/src/datastore/schemas/TableQueryFilter.ts 55.55% <18.75%> (-21.87%) ⬇️

... and 122 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit cd3f512 into star-whale:main Oct 19, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants