Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(SDK): avoid obtaining all artifact content in advance #2882

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

tianweidut
Copy link
Member

Description

  • For cifar10 example(spend 90s to finish evaluate phase):
    image

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2882 (87fdebf) into main (149c8aa) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2882      +/-   ##
==========================================
+ Coverage   92.35%   92.41%   +0.05%     
==========================================
  Files         125      122       -3     
  Lines       15351    15172     -179     
  Branches       44        0      -44     
==========================================
- Hits        14178    14021     -157     
+ Misses       1173     1151      -22     
Flag Coverage Δ
console ?
standalone 92.41% <100.00%> (-0.06%) ⬇️
unittests 92.41% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/starwhale/api/_impl/evaluation/log.py 100.00% <100.00%> (ø)
client/starwhale/base/data_type.py 95.92% <100.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit e89b619 into star-whale:main Oct 20, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants