Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): make unit test works after fastapi upgrade #2881

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Oct 19, 2023

Description

  • FastApi==0.104.0 requires typing-extensions>=4.8.0
  • TensorFlow requires typing-extensions<4.6.0

The unit test breaks when loading fastapi

/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/fastapi/exceptions.py:6: in <module>
    from typing_extensions import Annotated, Doc  # type: ignore [attr-defined]
E   ImportError: cannot import name 'Doc' from 'typing_extensions' (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/typing_extensions.py)

https://typing-extensions.readthedocs.io/en/latest/index.html#Doc

New in version 4.8.0: See PEP 727.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2881 (eeb79e1) into main (c4eb7df) will increase coverage by 9.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2881      +/-   ##
==========================================
+ Coverage   82.58%   92.48%   +9.90%     
==========================================
  Files           3      122     +119     
  Lines         178    15173   +14995     
  Branches       44        0      -44     
==========================================
+ Hits          147    14033   +13886     
- Misses         31     1140    +1109     
Flag Coverage Δ
console ?
standalone 92.48% <ø> (?)
unittests 92.48% <ø> (+9.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 125 files with indirect coverage changes

@jialeicui jialeicui marked this pull request as draft October 19, 2023 05:39
@jialeicui jialeicui changed the title chore(client): add version limit of fastapi chore(client): make unit test works after fastapi upgrade Oct 19, 2023
@jialeicui jialeicui marked this pull request as ready for review October 19, 2023 07:28
@tianweidut tianweidut merged commit 149c8aa into star-whale:main Oct 19, 2023
38 checks passed
@jialeicui jialeicui deleted the fix-dep branch October 19, 2023 08:03
goldenxinxing pushed a commit to goldenxinxing/starwhale that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants