Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): make sure evaluation log flushed to storage #2875

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Oct 18, 2023

Description

https://github.com/star-whale/starwhale/actions/runs/6562310747/job/17823986723?pr=2875

│ /home/runner/work/starwhale/starwhale/scripts/client_test/cli_test.py:294 in │
│                                                                              │
│   291 │   │   │   assert job_id                                              │
│   292 │   │   │   assert len(self.job_api.list())                            │
│   293 │   │   │   eval_info = self.job_api.info(job_id)                      │
│ ❱ 294 │   │   │   assert eval_info                                           │
│   295 │   │   │   assert eval_info["manifest"]["status"] in STATUS_SUCCESS   │
│   296 │   │   │   logger.info("finish run evaluation at standalone.")        │
│   297 │   │   │   job_ids.append(job_id)                                     │
╰──────────────────────────────────────────────────────────────────────────────╯
AssertionError
+ exit 1
+ cleanup

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft October 18, 2023 07:03
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2875 (4e48c1d) into main (149c8aa) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2875      +/-   ##
==========================================
- Coverage   92.35%   92.35%   -0.01%     
==========================================
  Files         125      122       -3     
  Lines       15351    15178     -173     
  Branches       44        0      -44     
==========================================
- Hits        14178    14018     -160     
+ Misses       1173     1160      -13     
Flag Coverage Δ
console ?
standalone 92.35% <100.00%> (-0.12%) ⬇️
unittests 92.35% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/starwhale/api/_impl/data_store.py 93.09% <100.00%> (+0.01%) ⬆️
client/starwhale/base/artifact/base.py 98.88% <100.00%> (+0.02%) ⬆️

... and 6 files with indirect coverage changes

@jialeicui jialeicui force-pushed the stable-e2e branch 9 times, most recently from ec89e03 to c118a6f Compare October 19, 2023 03:34
@jialeicui jialeicui changed the title fix(e2e): make job info stable fix(client): make sure evaluation log flushed to storage Oct 19, 2023
@jialeicui jialeicui added bug 🐛 Something isn't working client 🌈 labels Oct 19, 2023
@tianweidut tianweidut merged commit 488d702 into star-whale:main Oct 19, 2023
38 checks passed
@jialeicui jialeicui deleted the stable-e2e branch October 19, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working client 🌈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants