Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): prevent showing the 🆔 emoji in console #2871

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

jialeicui
Copy link
Contributor

Description

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2871 (41e735c) into main (62e4890) will increase coverage by 8.87%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2871      +/-   ##
============================================
+ Coverage     83.58%   92.46%   +8.87%     
============================================
  Files           542      122     -420     
  Lines         29662    15174   -14488     
  Branches       1679        0    -1679     
============================================
- Hits          24794    14030   -10764     
+ Misses         4108     1144    -2964     
+ Partials        760        0     -760     
Flag Coverage Δ
console ?
controller ?
standalone 92.46% <ø> (+0.04%) ⬆️
unittests 92.46% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/starwhale/base/scheduler/task.py 84.54% <ø> (ø)

... and 423 files with indirect coverage changes

@tianweidut tianweidut merged commit 3e41812 into star-whale:main Oct 17, 2023
38 checks passed
@jialeicui jialeicui deleted the fix-log-emoji branch October 17, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants