Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): failed task that is resumed have two runs #2869

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

anda-ren
Copy link
Member

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2869 (3ab1a58) into main (be16211) will decrease coverage by 9.36%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2869      +/-   ##
============================================
- Coverage     83.62%   74.27%   -9.36%     
- Complexity     2993     2994       +1     
============================================
  Files           542      417     -125     
  Lines         29664    14311   -15353     
  Branches       1681     1637      -44     
============================================
- Hits          24808    10630   -14178     
+ Misses         4093     2919    -1174     
+ Partials        763      762       -1     
Flag Coverage Δ
console ?
controller 74.27% <100.00%> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ai/starwhale/mlops/domain/job/cache/JobLoader.java 90.90% <100.00%> (-0.27%) ⬇️

... and 126 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 3a5ccc4 into star-whale:main Oct 17, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants