Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): fix when explicit_defaults_for_timestamp is off, run table could not be created #2865

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

anda-ren
Copy link
Member

fix when explicit_defaults_for_timestamp is off, run table could not be created

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2865 (3026127) into main (27f30e5) will decrease coverage by 9.37%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2865      +/-   ##
============================================
- Coverage     83.62%   74.25%   -9.37%     
- Complexity     2991     2992       +1     
============================================
  Files           542      417     -125     
  Lines         29659    14308   -15351     
  Branches       1679     1635      -44     
============================================
- Hits          24802    10625   -14177     
+ Misses         4095     2921    -1174     
  Partials        762      762              
Flag Coverage Δ
console ?
controller 74.25% <ø> (+<0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 126 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jialeicui jialeicui merged commit 85e592b into star-whale:main Oct 16, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants