Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): fix jobs that run on k8s are always cancelling when cancel operation is commited #2864

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Oct 16, 2023

Description

fix jobs that run on k8s are always cancelling when cancel operation is commited
Tests have passed in the cases:

  1. When pod is pending
  2. When container is creating
  3. When container is running

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added the bug 🐛 Something isn't working label Oct 16, 2023
@anda-ren anda-ren changed the title fix(controller): fix k8s scheduler is always cancelling fix(controller): fix jobs that run on k8s are always cancelling when cancel operation is commited Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2864 (9cd404d) into main (ae4c016) will decrease coverage by 9.43%.
Report is 6 commits behind head on main.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main    #2864      +/-   ##
============================================
- Coverage     83.66%   74.24%   -9.43%     
- Complexity     2988     2993       +5     
============================================
  Files           541      417     -124     
  Lines         29560    14310   -15250     
  Branches       1675     1637      -38     
============================================
- Hits          24732    10624   -14108     
+ Misses         4068     2925    -1143     
- Partials        760      761       +1     
Flag Coverage Δ
console ?
controller 74.24% <50.00%> (-0.08%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/schedule/impl/k8s/reporting/PodEventHandler.java 64.00% <50.00%> (+3.58%) ⬆️

... and 134 files with indirect coverage changes

@anda-ren anda-ren reopened this Oct 16, 2023
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit be16211 into star-whale:main Oct 16, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants