Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add list api for run #2815

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Oct 7, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #2815 (e08c24c) into main (3374c4e) will increase coverage by 0.02%.
The diff coverage is 88.63%.

@@             Coverage Diff              @@
##               main    #2815      +/-   ##
============================================
+ Coverage     83.56%   83.58%   +0.02%     
- Complexity     2976     2980       +4     
============================================
  Files           533      532       -1     
  Lines         29076    28943     -133     
  Branches       1667     1626      -41     
============================================
- Hits          24296    24192     -104     
+ Misses         4034     4004      -30     
- Partials        746      747       +1     
Flag Coverage Δ
console ?
controller 74.61% <76.19%> (+<0.01%) ⬆️
standalone 92.17% <100.00%> (+0.02%) ⬆️
unittests 92.17% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/starwhale/base/client/models/models.py 100.00% <100.00%> (ø)
...java/ai/starwhale/mlops/domain/run/RunService.java 100.00% <100.00%> (ø)
...ain/java/ai/starwhale/mlops/api/JobController.java 88.00% <50.00%> (-0.78%) ⬇️
...ava/ai/starwhale/mlops/api/protocol/run/RunVo.java 81.81% <81.81%> (ø)
...ain/java/ai/starwhale/mlops/domain/run/RunDao.java 84.00% <50.00%> (-6.48%) ⬇️

... and 6 files with indirect coverage changes

@anda-ren anda-ren marked this pull request as ready for review October 7, 2023 08:12
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit 824ae66 into star-whale:main Oct 8, 2023
28 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants