Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datastore): use flat structure to avoid too many sub directories #2809

Merged
merged 3 commits into from
Oct 8, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2809 (f721363) into main (5abbe1b) will increase coverage by 0.13%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2809      +/-   ##
==========================================
+ Coverage   92.02%   92.16%   +0.13%     
==========================================
  Files         125      122       -3     
  Lines       14943    14783     -160     
  Branches       43        0      -43     
==========================================
- Hits        13752    13625     -127     
+ Misses       1191     1158      -33     
Flag Coverage Δ
console ?
standalone 92.16% <100.00%> (+0.01%) ⬆️
unittests 92.16% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/starwhale/api/_impl/data_store.py 93.69% <100.00%> (+0.13%) ⬆️

... and 3 files with indirect coverage changes

@jialeicui jialeicui force-pushed the local-ds-storage branch 2 times, most recently from a98725c to 578f27b Compare September 28, 2023 04:43
@tianweidut
Copy link
Member

Others LGTM

tianweidut
tianweidut previously approved these changes Oct 8, 2023
@tianweidut tianweidut merged commit 731773c into star-whale:main Oct 8, 2023
42 checks passed
@jialeicui jialeicui deleted the local-ds-storage branch October 8, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants