Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(datastore): allow dumping when updating tables #2805

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Sep 26, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2805 (d69149e) into main (3977573) will decrease coverage by 9.05%.
Report is 3 commits behind head on main.
The diff coverage is 92.22%.

@@             Coverage Diff              @@
##               main    #2805      +/-   ##
============================================
- Coverage     83.40%   74.36%   -9.05%     
- Complexity     2944     2945       +1     
============================================
  Files           526      401     -125     
  Lines         28812    14041   -14771     
  Branches       1656     1623      -33     
============================================
- Hits          24031    10441   -13590     
+ Misses         4038     2859    -1179     
+ Partials        743      741       -2     
Flag Coverage Δ
console ?
controller 74.36% <92.22%> (+0.05%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...n/java/ai/starwhale/mlops/datastore/DataStore.java 85.17% <100.00%> (+1.41%) ⬆️
...a/ai/starwhale/mlops/datastore/wal/WalManager.java 84.75% <ø> (-2.44%) ⬇️
...hale/mlops/datastore/wal/WalRemoteFileManager.java 85.07% <ø> (ø)
...tarwhale/mlops/datastore/impl/MemoryTableImpl.java 87.02% <89.06%> (+<0.01%) ⬆️

... and 129 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit f9966dd into star-whale:main Sep 27, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants