Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller):tune dump period and add more logs #2630

Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Aug 18, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the chore 🛎️ some tiny change label Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #2630 (47594da) into main (314d851) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2630      +/-   ##
============================================
- Coverage     73.99%   73.95%   -0.05%     
  Complexity     2768     2768              
============================================
  Files           374      373       -1     
  Lines         13545    13463      -82     
  Branches       1553     1538      -15     
============================================
- Hits          10023     9956      -67     
+ Misses         2834     2817      -17     
- Partials        688      690       +2     
Flag Coverage Δ
console ?
controller 73.95% <100.00%> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...n/java/ai/starwhale/mlops/datastore/DataStore.java 86.78% <100.00%> (-0.42%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 7c83c23 into star-whale:main Aug 21, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants