Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): add editorconfig for server #2616

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added the chore 🛎️ some tiny change label Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #2616 (bf0c321) into main (34eac83) will decrease coverage by 8.38%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2616      +/-   ##
============================================
- Coverage     82.26%   73.89%   -8.38%     
+ Complexity     2759     2758       -1     
============================================
  Files           478      373     -105     
  Lines         25495    13388   -12107     
  Branches       1547     1533      -14     
============================================
- Hits          20974     9893   -11081     
+ Misses         3834     2807    -1027     
- Partials        687      688       +1     
Flag Coverage Δ
console ?
controller 73.89% <ø> (-0.01%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 106 files with indirect coverage changes

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 9cb7d3b into star-whale:main Aug 14, 2023
17 checks passed
@jialeicui jialeicui deleted the add-java-code-style-config branch August 14, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants