Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): enhance dataset build from huggingface for subsets #2608

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Aug 9, 2023

Description

Modules

  • Client
  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #2608 (2d3d3d9) into main (898e871) will increase coverage by 8.94%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2608      +/-   ##
============================================
+ Coverage     82.64%   91.59%   +8.94%     
============================================
  Files           454      104     -350     
  Lines         24882    11975   -12907     
  Branches       1509        0    -1509     
============================================
- Hits          20563    10968    -9595     
+ Misses         3654     1007    -2647     
+ Partials        665        0     -665     
Flag Coverage Δ
console ?
controller ?
standalone 91.59% <100.00%> (+<0.01%) ⬆️
unittests 91.59% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/starwhale/api/_impl/dataset/model.py 98.50% <ø> (ø)
client/starwhale/core/dataset/model.py 94.18% <ø> (ø)
client/starwhale/core/dataset/view.py 68.07% <ø> (ø)
...ient/starwhale/integrations/huggingface/dataset.py 98.68% <100.00%> (+0.17%) ⬆️

... and 350 files with indirect coverage changes

@tianweidut
Copy link
Member Author

cc @lijing-susan

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit 524f82f into star-whale:main Aug 10, 2023
38 checks passed
@tianweidut tianweidut deleted the enhance/hf-subsets branch September 5, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants