Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): update model case #2597

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Aug 5, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #2597 (eaa582d) into main (81bd2b6) will decrease coverage by 2.88%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2597      +/-   ##
============================================
- Coverage     82.63%   79.76%   -2.88%     
============================================
  Files           456        1     -455     
  Lines         24890       84   -24806     
  Branches       1509       14    -1495     
============================================
- Hits          20569       67   -20502     
+ Misses         3655       17    -3638     
+ Partials        666        0     -666     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller ?
standalone ?
unittests 79.76% <ø> (-11.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 455 files with indirect coverage changes

@tianweidut tianweidut merged commit a131af6 into star-whale:main Aug 5, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants