Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): online log with the correct pod #2565

Merged

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jul 26, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #2565 (de55cc8) into main (395b11c) will decrease coverage by 8.01%.
Report is 5 commits behind head on main.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##               main    #2565      +/-   ##
============================================
- Coverage     82.70%   74.70%   -8.01%     
- Complexity     2671     2673       +2     
============================================
  Files           450      348     -102     
  Lines         24525    12668   -11857     
  Branches       1481     1483       +2     
============================================
- Hits          20284     9463   -10821     
+ Misses         3579     2540    -1039     
- Partials        662      665       +3     
Flag Coverage Δ
controller 74.70% <40.00%> (-0.03%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...chedule/k8s/log/CancellableJobLogK8sCollector.java 52.17% <40.00%> (-12.12%) ⬇️

... and 104 files with indirect coverage changes

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 0b89d20 into star-whale:main Jul 27, 2023
17 checks passed
@jialeicui jialeicui deleted the fix-ws-log-when-failed-pod-exists branch July 27, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working controller 🏘️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants