Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(console): auth of dataset build list #2549

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

waynelwz
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz requested a review from jialeicui July 24, 2023 06:20
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #2549 (6c727c1) into main (bde12bb) will decrease coverage by 3.05%.
The diff coverage is n/a.

❗ Current head 6c727c1 differs from pull request most recent head a7da766. Consider uploading reports for the commit a7da766 to get more accurate results

@@             Coverage Diff              @@
##               main    #2549      +/-   ##
============================================
- Coverage     82.80%   79.76%   -3.05%     
============================================
  Files           451        1     -450     
  Lines         24562       84   -24478     
  Branches       1489       14    -1475     
============================================
- Hits          20339       67   -20272     
+ Misses         3563       17    -3546     
+ Partials        660        0     -660     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller ?
standalone ?
unittests 79.76% <ø> (-11.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 450 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit da4a76d into star-whale:main Jul 24, 2023
13 checks passed
@jialeicui jialeicui added the console 🎨 console label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants