Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(sdk): the localstore data will be auto dumpped when close the tablewriter #2511

Merged

Conversation

tianweidut
Copy link
Member

Description

related: #2510

Modules

  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #2511 (4b42d5b) into main (c8c6198) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2511      +/-   ##
==========================================
+ Coverage   91.35%   91.38%   +0.03%     
==========================================
  Files         102      102              
  Lines       11817    11821       +4     
==========================================
+ Hits        10795    10803       +8     
+ Misses       1022     1018       -4     
Flag Coverage Δ
standalone 91.38% <100.00%> (+0.03%) ⬆️
unittests 91.38% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/data_store.py 94.04% <100.00%> (+0.40%) ⬆️

jialeicui
jialeicui previously approved these changes Jul 17, 2023
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut force-pushed the enhance/dataset-dump-datastore branch from 25aa38e to 4b42d5b Compare July 17, 2023 05:57
@tianweidut tianweidut merged commit 435f699 into star-whale:main Jul 18, 2023
42 checks passed
@tianweidut tianweidut deleted the enhance/dataset-dump-datastore branch September 5, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants