Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): check if exists when upload built-in runtime in the progress of model copy #2493

Merged
merged 4 commits into from
Jul 11, 2023
Merged

fix(client): check if exists when upload built-in runtime in the progress of model copy #2493

merged 4 commits into from
Jul 11, 2023

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Jul 11, 2023 •
edited
Loading

Description

upload success when copy repeatly:
image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Jul 11, 2023
@goldenxinxing goldenxinxing changed the title fix(client): check if exists when upload built-in runtime in the progress of model copy WIP fix(client): check if exists when upload built-in runtime in the progress of model copy Jul 11, 2023
@goldenxinxing goldenxinxing changed the title WIP fix(client): check if exists when upload built-in runtime in the progress of model copy fix(client): check if exists when upload built-in runtime in the progress of model copy Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #2493 (0bdeb12) into main (b53ac85) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2493   +/-   ##
=========================================
  Coverage     83.52%   83.53%           
  Complexity     2604     2604           
=========================================
  Files           436      435    -1     
  Lines         23853    23774   -79     
  Branches       1415     1401   -14     
=========================================
- Hits          19923    19859   -64     
+ Misses         3298     3283   -15     
  Partials        632      632
Flag Coverage Δ
console ?
controller 76.15% <ø> (ø)
standalone 91.18% <100.00%> (-0.02%) ⬇️
unittests 91.18% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...starwhale/mlops/domain/runtime/RuntimeService.java 77.96% <ø> (ø)
client/starwhale/base/bundle_copy.py 96.57% <100.00%> (+0.12%) ⬆️

... and 2 files with indirect coverage changes

anda-ren
anda-ren approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit a0dde1e into star-whale:main Jul 11, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anda-ren anda-ren anda-ren approved these changes

@jialeicui jialeicui Awaiting requested review from jialeicui

Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goldenxinxing @anda-ren @jialeicui