Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): add datastore result view to job #2486

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Jul 10, 2023

Description

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz requested a review from jialeicui July 10, 2023 08:13
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #2486 (fcf74b1) into main (4c4c3ef) will decrease coverage by 3.74%.
The diff coverage is n/a.

❗ Current head fcf74b1 differs from pull request most recent head 87cf540. Consider uploading reports for the commit 87cf540 to get more accurate results

@@             Coverage Diff              @@
##               main    #2486      +/-   ##
============================================
- Coverage     83.49%   79.76%   -3.74%     
============================================
  Files           436        1     -435     
  Lines         23852       84   -23768     
  Branches       1415       14    -1401     
============================================
- Hits          19916       67   -19849     
+ Misses         3302       17    -3285     
+ Partials        634        0     -634     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller ?
standalone ?
unittests 79.76% <ø> (-11.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 435 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 7d5c229 into star-whale:main Jul 10, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants