fix(controller): dataset load with wrong key type (#2744)

star-whale · Sep 12, 2023 · 4c3eafc · 4c3eafc
1 parent ea5f06b
commit 4c3eafc
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/...er/src/main/java/ai/starwhale/mlops/domain/dataset/dataloader/DataStoreIndexProvider.java b/...er/src/main/java/ai/starwhale/mlops/domain/dataset/dataloader/DataStoreIndexProvider.java
@@ -56,10 +56,8 @@ public List<DataIndex> returnDataIndex(QueryDataIndexRequest request) {
             var records = dataStore.scan(DataStoreScanRequest.builder()
                     // start params must use the current cursor
                     .start(start)
-                    .startType("STRING")
                     .startInclusive(startInclusive)
                     .end(request.getEnd())
-                    .endType("STRING")
                     .endInclusive(request.isEndInclusive())
                     .keepNone(true)
                     .rawResult(false)

diff --git a/.../controller/src/test/java/ai/starwhale/mlops/domain/dataset/dataloader/ReadRangeTest.java b/.../controller/src/test/java/ai/starwhale/mlops/domain/dataset/dataloader/ReadRangeTest.java
@@ -77,10 +77,8 @@ public void testGenerateRange() {
         given(dataStore.scan(
                 DataStoreScanRequest.builder()
                         .start("0000-000")
-                        .startType("STRING")
                         .startInclusive(true)
                         .end("0000-008")
-                        .endType("STRING")
                         .endInclusive(true)
                         .keepNone(true)
                         .rawResult(false)
@@ -111,10 +109,8 @@ public void testGenerateRange() {
         given(dataStore.scan(
                 DataStoreScanRequest.builder()
                         .start("0000-008")
-                        .startType("STRING")
                         .startInclusive(false)
                         .end("0000-008")
-                        .endType("STRING")
                         .endInclusive(true)
                         .keepNone(true)
                         .rawResult(false)
@@ -201,10 +197,8 @@ public void testNextDataRange(boolean isSerial, int executeCount, ReadMode readM
         given(dataStore.scan(
                 DataStoreScanRequest.builder()
                         .start("0000-000")
-                        .startType("STRING")
                         .startInclusive(true)
                         .end("0000-008")
-                        .endType("STRING")
                         .endInclusive(true)
                         .keepNone(true)
                         .rawResult(false)