-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get locking information for note and add GitHub action for automatic deploying #4
base: main
Are you sure you want to change the base?
Conversation
Nice work! We do use yarn for everything in our repos so it would be ideal to stick with that. We can remove the engine requirements from the package.json file. I think it would also be better to update editor-kit with the version of the models package that you need, rather than overriding here, to make things simpler. |
@moughxyz Thank you! I'll update this PR to use yarn and remove the |
Done here standardnotes/app@5bfc608 |
Hi. I still get the following error message: |
The version of models with the removed engine requirement would have to be higher than the version it was in the fix commit, which was 1.47.8. |
@moughxyz Yes. I know the engine check has been removed in |
What about upgrading models package in editor kit? |
Yes. That's another solution. But actually, I think it will be better not to hard-code the dependency version. |
This PR does the following things:
gh-pages
branch.Editor.tsx
so that we can disable our editor if the note is locked. See the following video.standardnotes-template-screencast.mp4
I had a hard time figuring out how to implement the second feature because there is little documentation. I think other people will find this feature useful while implementing their own editor.
To achieve the second feature, there are a few changes:
@standardnotes/editor-kit
to the latest version.@standardnotes/models
version to use the latest version, which is hard-coded in the dependencies for@standardnotes/editor-kit
.yarn.lock
and usenpm
instead. We can also useyarn
but we need to useyarn install --ignore-engines
instead, which is cumbersome. Ifyarn
is needed, we must change theoverrides
field inpackage.json
toresolutions
. See https://stackoverflow.com/questions/40226639/how-do-i-override-nested-dependencies-with-yarn for details. But I think the better solution is not to hardcode@standardnotes/models
version in this file https://github.com/standardnotes/editor-kit/blob/c554d9f41423b9d4e8bfda847f541554d9aaf3d2/package.json