feat: support eslint v8

[theoludwig]

ESLint v8 has been released stable. 🎉
It's time to support eslint@8.

See: https://eslint.org/blog/2021/10/eslint-v8.0.0-released

Blocked by:

• Support ESLint 8.x import-js/eslint-plugin-import#2211
• feat: support ESLint 8.x mysticatea/eslint-plugin-node#295 (replaced by https://www.npmjs.com/package/eslint-plugin-n)
• Support ESLint 8.x eslint-community/eslint-plugin-promise#218

Closes #192

[voxpelli]

eslint-plugin-import @ v2.25.0 supports ESLint 8

[voxpelli]

@divlo Do you know if eslint-plugin-node requires an update? As its set to be compatible with all future versions of ESLint. Is ESLint 8 breaking it in any way?

[voxpelli]

Should we consider adding any of the news eslint:recommended rules? Probably wait for a major after this one, right?

• no-loss-of-precision
• no-nonoctal-decimal-escape
• no-unsafe-optional-chaining
• no-useless-backreference

[theoludwig]

@divlo Do you know if eslint-plugin-node requires an update? As its set to be compatible with all future versions of ESLint. Is ESLint 8 breaking it in any way?

I don't know if there's something breaking with ESLint v8.
We should probably wait a reply to your comment, to see how it goes: mysticatea/eslint-plugin-node#294 (comment) @voxpelli

[theoludwig]

Should we consider adding any of the news eslint:recommended rules? Probably wait for a major after this one, right?

• no-loss-of-precision
• no-nonoctal-decimal-escape
• no-unsafe-optional-chaining
• no-useless-backreference

Good idea! 👍
I think we can alreay include these new rules in the next major version as this PR will be released in a major version anyway.

But maybe just to make this PR small and separated, we could include these rules in another PR.

[voxpelli]

Good idea! 👍 I think we can alreay include these new rules in the next major version as this PR will be released in a major version anyway.

But maybe just to make this PR small and separated, we could include these rules in another PR.

We should always run new rules against the ecosystem and see how much they break and try to get all fixed first, as #148 and #166 has slowly been doing.

Speaking of: Would be good to get the PR:s for standard/standard#1702 out so that we can ship that in preparation for ESLint 8, as a preemptive measure

[voxpelli]

Does this affect us? (Mainly a note to self to check this) mysticatea/eslint-plugin-node#301

[voxpelli]

Does this affect us? (Mainly a note to self to check this) mysticatea/eslint-plugin-node#301

Yes it does:

eslint-config-standard/.eslintrc.json

Line 240 in 7460290

"node/process-exit-as-throw": "error",

[Nagarian]

It seems that eslint-plugin-promise as been updated to eslint 8 https://github.com/xjamundx/eslint-plugin-promise/blob/development/CHANGELOG.md

[J3m5]

It seems that eslint-plugin-promise as been updated to eslint 8 https://github.com/xjamundx/eslint-plugin-promise/blob/development/CHANGELOG.md

Related issue: #200

[fmal]

anything blocking this being merged now?

[theoludwig]

anything blocking this being merged now?

Nothing is blocking, it needs reviews! 😄

[wesleytodd]

Not that my approval means much as a non-contributor, but I pointed my project at this branch and ran with eslint@8 and it worked great. Really excited to finally be able to use private class properties with standard 🥇! Thanks for the good work team!

[yoyo837]

Friendly ping... @divlo

[voxpelli]

It’s not Divlo but the rest of us maintainers that are a bit slow at reviewing this, I myself have been taking time of programming now during the Christmas holiday, but hope to get around to this one any day now

[melroy89]

Yes, finally please.

[voxpelli]

I have now rolled a 17.0.0-0 prerelease of this.

You can install it using eslint-config-standard@next.

Being a pre-release, this one comes with no guarantees in regards to support / breaking changes etc. It exists to facilitate early feedback, from the wider community as well from our selves.

Next step now is to ship a prerelease of standard itself, to further validate the changes introduced here and minimize the risk for unintended breakage.

[manuman94]

Awesome! When will v17 stop being the @next to be the stable version?

[kleinfreund]

@manuman94 For information on this, please read #208 which tracks everything revolving around this process.

[manuman94]

Thank you! Sorry if this wasn't the place to ask. Greetings.