Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change Travis to GitHub actions #189

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

theoludwig
Copy link
Contributor

What changes did you make? (Give an overview)

  • Change travis configuration to GitHub Actions for continuous integration

This allows us to be consistent across the organization, we're slowly migrating to GitHub Actions.

Related: mightyiam/eslint-config-love#530, standard/standard-engine#233, standard/standard-engine#233

@theoludwig theoludwig self-assigned this Aug 14, 2021
@theoludwig theoludwig force-pushed the ci/change-travis-to-github-actions branch from 637d2c0 to c337cad Compare August 14, 2021 10:40
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simplify it a bit nowadays 🙂

I also wonder if we maybe would be helped by syncing these scripts using ghat? I do that for my repos, using my ghat templates here: https://github.com/voxpelli/ghatemplates

That way one don't have to remember to update the action, one can simply run a sync every now and then and see if some changes pop up.

And it's easier to know which of the action definitions that are the most modern and the one to copy from 🙂

.github/workflows/ci.yml Show resolved Hide resolved
@theoludwig
Copy link
Contributor Author

theoludwig commented Aug 14, 2021

@voxpelli

I also wonder if we maybe would be helped by syncing these scripts using ghat? I do that for my repos, using my ghat templates here: voxpelli/ghatemplates

I didn't know the existence of ghat, great suggestion!
I think you can open a new meta issue on standard/standard, so we could create a new repo to maintain GitHub Actions for the whole organization.

Meanwhile, that's probably out of the scope of this PR. 😄

@theoludwig theoludwig merged commit a41a81b into master Aug 15, 2021
@welcome
Copy link

welcome bot commented Aug 15, 2021

🎉 Congrats on getting your first pull request landed!

@theoludwig theoludwig deleted the ci/change-travis-to-github-actions branch August 15, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants