Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rules moved out from ESLint 7 #169

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Update to rules moved out from ESLint 7 #169

merged 1 commit into from
Oct 21, 2020

Conversation

LinusU
Copy link
Member

@LinusU LinusU commented May 11, 2020

This should (probably, right?) be a breaking change since we are changing a peer dependency.

Copy link
Contributor

@mightyiam mightyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my supposedly common sense, any rule change in this package is breaking. The peerDep as well.

In the standard package, this would not be a breaking change, if the rules behave the same. Since it would be too much work to guarantee this, I would simply mark it as a breaking change there, as well.

Did you go over each rule and see that they don't take new options or have different defaults or anything else that would alter the behavior from the deprecated core ESLint rules?

@LinusU
Copy link
Member Author

LinusU commented May 12, 2020

Well merge this together with #170 and bump the major version 👍

Did you go over each rule and see that they don't take new options or have different defaults or anything else that would alter the behavior from the deprecated core ESLint rules?

According to the release notes, the rules were simply copied from core:
https://github.com/mysticatea/eslint-plugin-node/releases/tag/v11.1.0

Copy link
Member

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feross feross merged commit e5e366d into master Oct 21, 2020
@feross feross deleted the eslint7 branch October 21, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants