Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/3316 median abs dev #3319

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

mitzimorris
Copy link
Member

@mitzimorris mitzimorris commented Nov 28, 2024

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Changed function name from max_abs_deviation to med_abs_deviation

Intended Effect

code cleanup

How to Verify

unit tests

Side Effects

will need companion PR for CmdStan

Documentation

N/A

Copyright and Licensing

Columbia University

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@mitzimorris
Copy link
Member Author

can this and the CmdStan PR be merged for the next RC?

@WardBrian
Copy link
Member

Yes, we just have to merge them while they're both failing and then it will eventually reach consistency

@mitzimorris mitzimorris merged commit 42731ba into develop Nov 29, 2024
2 of 3 checks passed
@mitzimorris mitzimorris deleted the cleanup/3316-median-abs-dev branch November 29, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants