Remove usages of io::rdump
from unrelated tests, util functions
#3267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
We've been recommending against using the R dump format for a while (see stan-dev/cmdstan#1177), but we were still using it for a lot of tests (sometimes completely unnecessarily), and for the two helper functions
create_unit_e_diag_inv_metric
andcreate_unit_e_dense_inv_metric
, which were both implemented by creating a string and then parsing it again.Intended Effect
Clean up unnecessary usages of
io::dump
in tests, replace others with json data, and refactor utilities that don't need to do parsing to not do it.How to Verify
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: