Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of io::rdump from unrelated tests, util functions #3267

Merged
merged 9 commits into from
Feb 8, 2024

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

We've been recommending against using the R dump format for a while (see stan-dev/cmdstan#1177), but we were still using it for a lot of tests (sometimes completely unnecessarily), and for the two helper functions create_unit_e_diag_inv_metric and create_unit_e_dense_inv_metric, which were both implemented by creating a string and then parsing it again.

Intended Effect

Clean up unnecessary usages of io::dump in tests, replace others with json data, and refactor utilities that don't need to do parsing to not do it.

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a much-needed cleanup - thank you so much for doing this!

@WardBrian WardBrian merged commit b6d010f into develop Feb 8, 2024
3 checks passed
@WardBrian WardBrian deleted the cleanup/rdump-deprecation branch February 8, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants