Merge pull request #3238 from stan-dev/fix/optimize-log-error

Log optimization errors on error channel
stan-dev · Nov 6, 2023 · a6af397 · a6af397
2 parents 07e86a8 + 5c4eb96
commit a6af397
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/stan/services/optimize/bfgs.hpp b/src/stan/services/optimize/bfgs.hpp
@@ -172,14 +172,16 @@ int bfgs(Model& model, const stan::io::var_context& init,
   }
 
   int return_code;
+  auto error_string = bfgs.get_code_string(ret);
   if (ret >= 0) {
     logger.info("Optimization terminated normally: ");
+    logger.info("  " + error_string);
     return_code = error_codes::OK;
   } else {
     logger.error("Optimization terminated with error: ");
+    logger.error("  " + error_string);
     return_code = error_codes::SOFTWARE;
   }
-  logger.info("  " + bfgs.get_code_string(ret));
 
   return return_code;
 }

diff --git a/src/stan/services/optimize/lbfgs.hpp b/src/stan/services/optimize/lbfgs.hpp
@@ -176,14 +176,17 @@ int lbfgs(Model& model, const stan::io::var_context& init,
   }
 
   int return_code;
+  auto error_string = lbfgs.get_code_string(ret);
+
   if (ret >= 0) {
     logger.info("Optimization terminated normally: ");
+    logger.info("  " + error_string);
     return_code = error_codes::OK;
   } else {
     logger.error("Optimization terminated with error: ");
+    logger.error("  " + error_string);
     return_code = error_codes::SOFTWARE;
   }
-  logger.info("  " + lbfgs.get_code_string(ret));
 
   return return_code;
 }