-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "babel" field in package.json for react-native support #266
Remove "babel" field in package.json for react-native support #266
Conversation
Wow. Awesome! Cheers |
Looks good to me as well. I remember (although bit foggy) that we had to do it like this because of ES2015 preset transpiling those ES modules and babel-preset-es2015-rollup wasn't working that well. It's bit problematic, that build might actually pass, but don't have exactly tools to automatically verify that those builds are really working properly. |
First of all, thank you very much @Piroro-hs for that cool deep techy contribution. I checked the final resulting bundle.
var _typeof = typeof Symbol === "function" && typeof Symbol.iterator === "symbol" ?
function (obj) { return typeof obj; } : function (obj) { return obj &&
typeof Symbol === "function" && obj.constructor === Symbol &&
obj !== Symbol.prototype ? "symbol" : typeof obj; }; which replaces the
Is there a way to get rid of that "symbol" support in those functions? P.S. |
Babel is obviously over complicated, let's check out Bublé :) #267 |
It would be great is I'm liking the Buble approach very much. @Piroro-hs would #267 resolve your issue? |
I've just tried the #267 repo and it works perfectly!(^^) |
Great! Closing this one. :) |
@Piroro-hs published stampit v3.0.4 |
React-native-packager try to use babel config in package.json or .babelrc and throw "Unknown plugin" error.
This PR will solve this issue and allow using stampit with react-native.
facebook/react-native#4062
react-native TransformError when requiring a node_module that has a package.json with a babel config that specifies uninstalled plugin (stackoverflow)