This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
Sync with reactjs.org @ 841d3d1b #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Text "Click me" in the button confuses first-time users because it forces them to actually click on the button in the live demo but it does nothing. By changing the text, we can control the user behavior as they don't expect anything on that click.
* add loading indicator to sidebar links * fix clicking on same route whould show indicator * maybe final? * handle routeChangeError as well as cleaning up timeout * clearing timeout before creating one instead of routeChangeError * rm unused * add license header * Update usePendingRoute.ts Co-authored-by: dan <[email protected]>
* fix(eslint): messages severity * .
"them" word was missing
Fixed TypeScript hyperlink to the correct website.
This reverts commit 2d46af6.
These are now pointing at a different event, I've left/updated the video links though for posterity
* add remix conf * add remix conf 2023
* [Beta] Optimize some performance * Unnecessary image optimization * Unused optimizeFonts
* fix(navigation): ui tweak * revert border color
* added code for sandpack console * add log * added console for older bundle * Revert "[beta] Sandpack - new bundler (#4458)" This reverts commit 3ab1245. * adds proper console and removes new bundle * modify styles * remove unwanted code * nit * fix types (#4677) * update console * little nits * remove unwanted code changes * update bundler URL * use `message.firstLoad` for clearing console * use `refresh` event to clear logs as well (used when going away and coming back to sandpack) * remove padding for code blocks inside console * small UI revamps * change p to div since the sandpack comes inside the p, add try catch and a try catch for the catch again * tweaks * Fixes * Reset unrelated changes * tweaks * fix * fixes * oops * Fix * fix Co-authored-by: Danilo Woznica <[email protected]> Co-authored-by: Dan Abramov <[email protected]>
* [WIP] Effects * More * More * Typo * More * tweaks * typo * note * Add playsinline * Fix * Typo * Oops * More content * Compress a bit * edits * oops * Tweaks * tweak * Inline the deep dive * fix * typos * add deep dive * oops * Clarify * Add third case * oops * edit * [beta][effects] Reword effects-in-render counterexample (#4722) * reframe * oops * ok * edits * fix * remove special styling * tweak * oops * tweak * challenges * tweaks Co-authored-by: Sophie Alpert <[email protected]>
changing the link from http to https since the http version seems not to get forwarded (404)
* [Beta] Update `Describing the UI` Doc content format * [Beta] Update link * [Beta] Revert
* [beta] Remove 'each next' and 'every next' * Update beta/src/content/apis/react/useCallback.md Co-authored-by: Ricky <[email protected]> * Update separating-events-from-effects.md * Update you-might-not-need-an-effect.md Co-authored-by: Ricky <[email protected]> Co-authored-by: dan <[email protected]>
* [beta] Add flushSync docs * tweaks * tweaks Co-authored-by: Dan Abramov <[email protected]>
* [Beta] Fragment edits * Add some links
* Initial forwardRef draft * more info * more link * oops Co-authored-by: Arati Chilad <[email protected]>
* [Beta] Initial API doc for Suspense This doesn't include everything but I think it's good enough for a start. I didn't add any interactive examples yet because I want to use the `use` API, so I'll wait until that's documented. * edits Co-authored-by: Dan Abramov <[email protected]>
* Create Fragment API reference page * Minor formatting changes * Create memo API reference page * [beta] Dan's suggestions for memo * Update beta/src/content/apis/react/memo.md Co-authored-by: Strek <[email protected]> * edits Co-authored-by: Rick Hanlon <[email protected]> Co-authored-by: Strek <[email protected]> Co-authored-by: Dan Abramov <[email protected]>
…" changed to false. Since there can be only one empty message when the initial state of "showForm" changed from true to false. (#5071)
fix typo on you-might-not-need-an-effect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at 841d3d1
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.