Fix flashloanOsTokenShares zero check

stakewise · Sep 29, 2024 · 3a8325e · 3a8325e
1 parent 10b7b1b
commit 3a8325e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/.forge-snapshots/EthAaveLeverageStrategyTest_test_deposit_HasPosition.snap b/.forge-snapshots/EthAaveLeverageStrategyTest_test_deposit_HasPosition.snap
@@ -1 +1 @@
-844627
+844583
diff --git a/.forge-snapshots/EthAaveLeverageStrategyTest_test_deposit_NoPosition.snap b/.forge-snapshots/EthAaveLeverageStrategyTest_test_deposit_NoPosition.snap
@@ -1 +1 @@
-954568
+954552
diff --git a/.forge-snapshots/EthAaveLeverageStrategyTest_test_permit.snap b/.forge-snapshots/EthAaveLeverageStrategyTest_test_permit.snap
@@ -1 +1 @@
-379514
+379495
diff --git a/.forge-snapshots/EthAaveLeverageStrategyTest_test_rescueLendingAssets2.snap b/.forge-snapshots/EthAaveLeverageStrategyTest_test_rescueLendingAssets2.snap
@@ -1 +1 @@
-533356
+533343
diff --git a/src/leverage/LeverageStrategy.sol b/src/leverage/LeverageStrategy.sol
@@ -162,15 +162,15 @@ abstract contract LeverageStrategy is Multicall, ILeverageStrategy {
 
             // mint max possible osToken shares
             leverageOsTokenShares = _mintOsTokenShares(vault, proxy, assetsToBorrow, type(uint256).max);
-            if (leverageOsTokenShares == 0) {
-                // no osToken shares to leverage
-                emit Deposited(vault, msg.sender, osTokenShares, 0);
-                return;
-            }
         }
 
         // calculate flash loaned osToken shares
         uint256 flashloanOsTokenShares = _getFlashloanOsTokenShares(vault, leverageOsTokenShares);
+        if (flashloanOsTokenShares == 0) {
+            // no osToken shares to leverage
+            emit Deposited(vault, msg.sender, osTokenShares, 0);
+            return;
+        }
 
         // execute flashloan
         _osTokenFlashLoans.flashLoan(flashloanOsTokenShares, abi.encode(FlashloanAction.Deposit, vault, proxy));