Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WAGYU-38] System check page refactor #67

Merged
merged 7 commits into from
Aug 25, 2021
Merged

[WAGYU-38] System check page refactor #67

merged 7 commits into from
Aug 25, 2021

Conversation

peebeejay
Copy link
Collaborator

@peebeejay peebeejay commented Aug 20, 2021 •
edited
Loading

Closes:
#38
#61

This PR contains work that:

  • Updates storybook to have a simulated router
  • Splits up the system check page
  • Adds new React devtools to the chrome inspector
  • Fixes minor styling issues
  • Fix the system check loading flash issue

@peebeejay peebeejay marked this pull request as ready for review August 24, 2021 19:08
@peebeejay peebeejay requested a review from colfax23 August 24, 2021 19:14
colfax23
colfax23 approved these changes Aug 25, 2021
View reviewed changes
Copy link
Collaborator

@colfax23 colfax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work. Much clearer code than the previous version.

@colfax23 colfax23 merged commit 041f354 into stake-house:main Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colfax23 colfax23 colfax23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peebeejay @colfax23