Skip to content

Commit

Permalink
Handle make verify errors
Browse files Browse the repository at this point in the history
  • Loading branch information
ahmedwaleedmalik committed Aug 7, 2020
1 parent 399c05c commit 9619486
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions controllers/project_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ package controllers

import (
"context"
"time"

"github.com/go-logr/logr"
"k8s.io/apimachinery/pkg/api/errors"
Expand All @@ -32,8 +31,9 @@ import (
)

const (
defaultRequeueTime = 60 * time.Second
ProjectFinalizer string = "jiraservicedesk.stakater.com/project"
// TODO: Check if this is required in our case
// defaultRequeueTime = 60 * time.Second
ProjectFinalizer string = "jiraservicedesk.stakater.com/project"
)

// ProjectReconciler reconciles a Project object
Expand Down Expand Up @@ -142,13 +142,13 @@ func (r *ProjectReconciler) handleCreate(req ctrl.Request, instance *jiraservice
func (r *ProjectReconciler) handleDelete(req ctrl.Request, instance *jiraservicedeskv1alpha1.Project) (ctrl.Result, error) {
log := r.Log.WithValues("project", req.NamespacedName)

log.Info("Deleting Jira Service Desk Project: " + instance.Spec.Name)

if instance == nil {
// Instance not found, nothing to do
return util.DoNotRequeue()
}

log.Info("Deleting Jira Service Desk Project: " + instance.Spec.Name)

// Delete project from JSD
err := r.JiraServiceDeskClient.DeleteProject(instance.Status.ID)
if err != nil {
Expand Down

0 comments on commit 9619486

Please sign in to comment.