Skip to content

Commit

Permalink
Replace lint step with official action
Browse files Browse the repository at this point in the history
  • Loading branch information
ahmedwaleedmalik committed Aug 16, 2021
1 parent 50efdf8 commit 5a0e674
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ env:
GOLANG_VERSION: 1.16
KUBERNETES_VERSION: "1.20.2"
KIND_VERSION: "0.10.0"
GOLANG_CI_LINT_VERSION: v1.39.0

jobs:
build:
Expand All @@ -30,10 +29,11 @@ jobs:
go-version: ${{ env.GOLANG_VERSION }}

- name: Lint
run: |
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${{ env.GOLANG_CI_LINT_VERSION }}
golangci-lint run --timeout=10m ./...
uses: golangci/[email protected]
with:
version: v1.39.0
only-new-issues: false
args: --timeout 10m

- name: Install kubectl
run: |
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ env:
KUSTOMIZE_VERSION: "3.5.4"
KUBERNETES_VERSION: "1.20.2"
KIND_VERSION: "0.10.0"
GOLANG_CI_LINT_VERSION: v1.39.0

jobs:
build:
Expand All @@ -34,9 +33,11 @@ jobs:
go-version: ${{ env.GOLANG_VERSION }}

- name: Lint
run: |
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${{ env.GOLANG_CI_LINT_VERSION }}
golangci-lint run --timeout=10m ./...
uses: golangci/[email protected]
with:
version: v1.39.0
only-new-issues: false
args: --timeout 10m

- name: Install kubectl
run: |
Expand Down

0 comments on commit 5a0e674

Please sign in to comment.