Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add vertical pod autoscaler template #249

Merged
merged 14 commits into from
Jul 6, 2023
Merged

feat: Add vertical pod autoscaler template #249

merged 14 commits into from
Jul 6, 2023

Conversation

OsamaKhan220
Copy link
Contributor

@OsamaKhan220 OsamaKhan220 commented Apr 3, 2023 •
edited by rasheedamir
Loading

Fixes #32

@github-actions
Copy link

github-actions bot commented Apr 3, 2023 •
edited
Loading

@aslafy-z validation successful`

@rasheedamir rasheedamir requested a review from d3adb5 April 3, 2023 13:36
@rasheedamir
Copy link
Member

@d3adb5 @mustafaStakater can you plz review it?

d3adb5
d3adb5 previously requested changes Apr 7, 2023
View reviewed changes
application/templates/vpa.yaml Outdated Show resolved Hide resolved
@mustafaStakater
Copy link
Contributor

Add helm uninstall openshift-vertical-pod-autoscaler -n openshift-vertical-pod-autoscaler command in Tiltfile-delete.

aslafy-z
aslafy-z reviewed Apr 14, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
aslafy-z
aslafy-z reviewed Jul 5, 2023
View reviewed changes
Tiltfile Show resolved Hide resolved
@aslafy-z aslafy-z changed the title Add vertical pod autoscaler template feat: Add vertical pod autoscaler template Jul 5, 2023
aslafy-z
aslafy-z previously approved these changes Jul 5, 2023
View reviewed changes
@aslafy-z aslafy-z dismissed d3adb5’s stale review July 5, 2023 11:17

Change done

d3adb5
d3adb5 requested changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@d3adb5 d3adb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a prompt that could become a suggestion, and apart from what I think is an erroneous string, this looks good to me.

Tiltfile-delete Outdated Show resolved Hide resolved
Tiltfile Outdated Show resolved Hide resolved
d3adb5
d3adb5 previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@d3adb5 d3adb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minus the currently unavoidable merge conflict. 👍

@aslafy-z aslafy-z merged commit 438792b into master Jul 6, 2023
@aslafy-z aslafy-z deleted the vpa-support branch July 6, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasheedamir rasheedamir rasheedamir left review comments

@aslafy-z aslafy-z aslafy-z approved these changes

@d3adb5 d3adb5 d3adb5 left review comments

@mustafaStakater mustafaStakater Awaiting requested review from mustafaStakater

@karl-johan-grahn karl-johan-grahn Awaiting requested review from karl-johan-grahn

@hussnain612 hussnain612 Awaiting requested review from hussnain612

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add VPA manifest
6 participants
@OsamaKhan220 @rasheedamir @mustafaStakater @aslafy-z @d3adb5 @hussnain612