Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing entries to CHANGELOG.md #248

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

aslafy-z
Copy link
Collaborator

@aslafy-z aslafy-z commented Apr 3, 2023

Add missing entries to CHANGELOG.md

CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

@aslafy-z validation successful`

@mustafaStakater
Copy link
Contributor

Ah, i need to look into automatic changelog updates

also , this will cause main pipeline to be triggered because skip-ci might not work according to ref below

If any commit message in your push or the HEAD commit of your PR contains the strings [skip ci], [ci skip], [no ci], [skip actions], or [actions skip] workflows triggered on the push or pull_request events will be skipped.
Ref: https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/

@aslafy-z
Copy link
Collaborator Author

aslafy-z commented Apr 3, 2023

@mustafaStakater This is the job I want to skip: https://github.com/stakater/application/blob/master/.github/workflows/push.yaml#L21. Will this pipeline still triggered?

@mustafaStakater
Copy link
Contributor

yes pipeline will be triggered, for some reason, [skip-ci] in commit message doesnt skip workflows, i wasnt able to investigate it.

Add missing entries to changelog.md
@aslafy-z
Copy link
Collaborator Author

aslafy-z commented Apr 3, 2023

Ok. I just updated the commit with 'skip ci' instead of 'skip-ci'

@aslafy-z aslafy-z changed the title chore: Fix CHANGELOG.md chore: Add missing entries to CHANGELOG.md Apr 3, 2023
@mustafaStakater mustafaStakater merged commit dac25b3 into master Apr 3, 2023
@mustafaStakater mustafaStakater deleted the aslafy-z-patch-1 branch April 3, 2023 12:21
@aslafy-z
Copy link
Collaborator Author

aslafy-z commented Apr 3, 2023

@mustafaStakater it did not work. The release job was executed :(

@mustafaStakater
Copy link
Contributor

mustafaStakater commented Apr 3, 2023

yes, this seems weird, gh action supports this , shouldve worked acc to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants